fries/quickjs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove js_unlikely macro (#370)

Browse source 
It was a wrapper around gcc's __builtin_expect macro but it was only
used in three places and not in a way that suggests it really helps
branch prediction on modern (or even not so modern) CPUs.

Refs: https://github.com/quickjs-ng/quickjs/issues/369
This commit is contained in:
Ben Noordhuis 2024-04-12 12:21:20 +02:00 committed by GitHub
parent b20aad8d1a
commit 325ce95c5e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
quickjs.h
View file

@ -35,12 +35,10 @@ extern "C" {
#endif #endif
#if defined(__GNUC__) || defined(__clang__) #if defined(__GNUC__) || defined(__clang__)
#define js_unlikely(x) __builtin_expect(!!(x), 0)
#define js_force_inline inline __attribute__((always_inline)) #define js_force_inline inline __attribute__((always_inline))
#define __js_printf_like(f, a) __attribute__((format(printf, f, a))) #define __js_printf_like(f, a) __attribute__((format(printf, f, a)))
#define JS_EXTERN __attribute__((visibility("default"))) #define JS_EXTERN __attribute__((visibility("default")))
#else #else
#define js_unlikely(x) (x)
#define js_force_inline inline #define js_force_inline inline
#define __js_printf_like(a, b) #define __js_printf_like(a, b)
#define JS_EXTERN /* nothing */ #define JS_EXTERN /* nothing */
@ -124,7 +122,7 @@ static inline JSValue __JS_NewFloat64(double d)
JSValue v; JSValue v;
u.d = d; u.d = d;
/* normalize NaN */ /* normalize NaN */
if (js_unlikely((u.u64 & 0x7fffffffffffffff) > 0x7ff0000000000000)) if ((u.u64 & 0x7fffffffffffffff) > 0x7ff0000000000000)
v = JS_NAN; v = JS_NAN;
else else
v = u.u64 - ((uint64_t)JS_FLOAT64_TAG_ADDEND << 32); v = u.u64 - ((uint64_t)JS_FLOAT64_TAG_ADDEND << 32);
@ -538,12 +536,12 @@ static inline JS_BOOL JS_IsUndefined(JSValue v)
static inline JS_BOOL JS_IsException(JSValue v) static inline JS_BOOL JS_IsException(JSValue v)
{ {
return js_unlikely(JS_VALUE_GET_TAG(v) == JS_TAG_EXCEPTION); return JS_VALUE_GET_TAG(v) == JS_TAG_EXCEPTION;
} }
static inline JS_BOOL JS_IsUninitialized(JSValue v) static inline JS_BOOL JS_IsUninitialized(JSValue v)
{ {
return js_unlikely(JS_VALUE_GET_TAG(v) == JS_TAG_UNINITIALIZED); return JS_VALUE_GET_TAG(v) == JS_TAG_UNINITIALIZED;
} }
static inline JS_BOOL JS_IsString(JSValue v) static inline JS_BOOL JS_IsString(JSValue v)
@ -997,7 +995,6 @@ JS_EXTERN JSValue JS_PromiseResult(JSContext *ctx, JSValue promise);
JS_EXTERN const char* JS_GetVersion(void); JS_EXTERN const char* JS_GetVersion(void);
#undef JS_EXTERN #undef JS_EXTERN
#undef js_unlikely
#undef js_force_inline #undef js_force_inline
#undef __js_printf_like #undef __js_printf_like