fries/quickjs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Disable flaky test on Cygwin (#202)

Browse source 
Unclear why sending a SIGQUIT signal sometimes works and sometimes
doesn't but it's probably some kind of race condition in Cygwin's
emulation layer.

Fixes: https://github.com/quickjs-ng/quickjs/issues/184
This commit is contained in:
Ben Noordhuis 2023-12-11 22:02:32 +01:00 committed by GitHub
parent de44a37ae9
commit 40771c9103
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tests/test_std.js
View file

@ -2,6 +2,7 @@ import * as std from "std";
import * as os from "os"; import * as os from "os";
const isWin = os.platform === 'win32'; const isWin = os.platform === 'win32';
const isCygwin = os.platform === 'cygwin';
function assert(actual, expected, message) { function assert(actual, expected, message) {
if (arguments.length == 1) if (arguments.length == 1)
@ -246,8 +247,12 @@ function test_os_exec()
os.kill(pid, os.SIGTERM); os.kill(pid, os.SIGTERM);
[ret, status] = os.waitpid(pid, 0); [ret, status] = os.waitpid(pid, 0);
assert(ret, pid); assert(ret, pid);
// Flaky on cygwin for unclear reasons, see
// https://github.com/quickjs-ng/quickjs/issues/184
if (!isCygwin) {
assert(status & 0x7f, os.SIGTERM); assert(status & 0x7f, os.SIGTERM);
} }
}
function test_timer() function test_timer()
{ {